Require 'date' to avoid retry exception #1206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without requiring 'date', we get an exception in the retry middleware
when it tries to use DateTime for handling the Retry-After header.
Description
This simple script can be used to reproduce the bug:
The fix is to simply add a require for Ruby's
date
library so we don't get an exception during retries.I'm not certain this warrants a spec change (or if that'd even be possible?) but please let me know!